Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayTile: wrong argument order in combineDouble + ConstantTile #3257

Closed
jdries opened this issue Jun 17, 2020 · 0 comments · Fixed by #3273
Closed

ArrayTile: wrong argument order in combineDouble + ConstantTile #3257

jdries opened this issue Jun 17, 2020 · 0 comments · Fixed by #3273
Labels
bug

Comments

@jdries
Copy link
Contributor

jdries commented Jun 17, 2020

In ArrayTile, combineDouble looks like:

case ct: ConstantTile => ct.combineDouble(this)(f)

compare to combine:
case ct: ConstantTile => ct.combine(this)((z1, z2) => f(z2, z1))

So the argument order in combineDouble is (z1,z2). When using this in combination with the non-commutative 'Subtract' function, results are simply wrong. (So I believe this can be considered a pretty major issue.)
jdries added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Jun 17, 2020
@jdries
EP-3439 make gamma0 work, taking into account geotrellis bug: locatio…
9f1b738 
…ntech/geotrellis#3257
@pomadchin pomadchin added the bug label Jun 17, 2020
jdries added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Jun 19, 2020
@jdries
EP-3439 have to use multiply due to geotrellis bug
20ef640 
locationtech/geotrellis#3257
soxofaan added a commit to soxofaan/geotrellis that referenced this issue Jul 22, 2020
@soxofaan
Issue locationtech#3257: fix ArrayTile.combineDouble with ConstantTile
b007cfb
@soxofaan soxofaan mentioned this issue Jul 22, 2020
Merged
2 tasks
soxofaan added a commit to soxofaan/geotrellis that referenced this issue Jul 22, 2020
@soxofaan
Issue locationtech#3257: fix ArrayTile.combineDouble with ConstantTile
70edf53
soxofaan added a commit to soxofaan/geotrellis that referenced this issue Jul 22, 2020
@soxofaan
Issue locationtech#3257: fix ArrayTile.combineDouble with ConstantTile
a85b076 
Signed-off-by: Stefaan Lippens <[email protected]>
pomadchin added a commit that referenced this issue Aug 4, 2020
@soxofaan @pomadchin
Issue #3257: fix ArrayTile.combineDouble with ConstantTile (#3273)
b9355ee 
Signed-off-by: Stefaan Lippens <[email protected]>

Co-authored-by: Grigory <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #3257: fix ArrayTile.combineDouble with ConstantTile soxofaan/geotrellis
2 participants
@pomadchin @jdries