Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In S3GeoTiffReader, partitionBytes has no effect if maxTileSize is set #2232

Closed
lossyrob opened this issue Jun 9, 2017 · 1 comment · Fixed by #2233
Closed

In S3GeoTiffReader, partitionBytes has no effect if maxTileSize is set #2232

lossyrob opened this issue Jun 9, 2017 · 1 comment · Fixed by #2233
Assignees
@lossyrob
Labels
bug
Milestone
1.1

Comments

@lossyrob
Copy link
Member

lossyrob commented Jun 9, 2017

partitionBytes only has an effect in S3InputFormat, and is not taken into consideration when reading windows via maxTileSize. We should modify the maxTileSize path to try and respect this option.
@lossyrob lossyrob added the bug label Jun 9, 2017
@lossyrob lossyrob added this to the 1.1 milestone Jun 9, 2017
@lossyrob
Copy link
Member Author

lossyrob commented Jun 9, 2017

It would take deeper and API breaking changes to allow this option to occur, so a logged warning will suffice.

lossyrob added a commit to lossyrob/geotrellis that referenced this issue Jun 9, 2017
@lossyrob
Fix to issue locationtech#2232
7a43bf6
@lossyrob lossyrob mentioned this issue Jun 9, 2017
Merged
@lossyrob lossyrob self-assigned this Jun 9, 2017
lossyrob added a commit to lossyrob/geotrellis that referenced this issue Jun 22, 2017
@lossyrob
Fix to issue locationtech#2232
dc0ab4a
lossyrob added a commit that referenced this issue Jun 22, 2017
@lossyrob
Merge pull request #2252 from lossyrob/backport/1.1/2233
3709d33 
[BACKPORT 1.1] Fixes to #2231 and #2232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lossyrob lossyrob

Labels
bug
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Example for creating a MultiBandTile RDD from Landsat GeoTiffs. lossyrob/geotrellis
2 participants
@lossyrob @pomadchin