GEOMESA-3426 FSDS - Support path filtering for converter queries #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminding myself to update the docs |
elahrvivaz
reviewed
Dec 13, 2024
...-fs-storage-api/src/main/scala/org/locationtech/geomesa/fs/storage/api/StorageMetadata.scala
Outdated
Show resolved
Hide resolved
elahrvivaz
reviewed
Dec 13, 2024
...s-storage-api/src/main/scala/org/locationtech/geomesa/fs/storage/api/PathFilterFactory.scala
Outdated
Show resolved
Hide resolved
fdfea
force-pushed
the
ffeaser_fsds_path_filter
branch
2 times, most recently
from
fb05e71 to
a530c4c
Compare
fdfea
force-pushed
the
ffeaser_fsds_path_filter
branch
from
a530c4c to
d2e3424
Compare
fdfea
changed the title
elahrvivaz
reviewed
Dec 16, 2024
| val pathFiltering = Option(context.conf.get(PathFilterName)).flatMap { name => | ||
| val factory = PathFilteringFactory.load(NamedOptions(name, pathFilteringOpts.toMap)) | ||
| if (factory.isEmpty) { | ||
| logger.warn(s"Failed to load ${classOf[PathFiltering].getName} for config '$name'") |
There was a problem hiding this comment.
do you think a warning is ok here, or should we throw an error? i worry people might not notice the warning, and then get worse performance but since things still work correctly they might not realize the mistake
elahrvivaz
changed the title
added 2 commits
December 16, 2024 15:47
|
@elahrvivaz I've tested with real data on my end and it seems to be working expected. Could we also get this in a 5.0.x release? |
|
thanks for remembering the docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.