Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOMESA-3423 - add unlogged user data option #3244

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

autodidacticon
Copy link
Contributor

@autodidacticon autodidacticon commented Dec 10, 2024

@elahrvivaz

  • Added user-data option pg.wal.log.enabled, if set to false all postgis-partitioned tables will be created as unlogged
  • added a test to PartitionedPostgisDataStoreTest to verify that tables are unlogged when option is set
  • added a test to PartitionedPostgisDataStoreTest to verify that tables are logged when option is unset

@elahrvivaz
Copy link
Contributor

thanks for this! could you add the new config to the docs at https://raw.githubusercontent.com/locationtech/geomesa/refs/heads/main/docs/user/postgis/index_config.rst ?

@elahrvivaz
Copy link
Contributor

elahrvivaz commented Dec 10, 2024

a few of these tables are shared between different feature types - to avoid them being created differently depending on which feature type is created first, could you revert the changes to PartitionTablespacesTable, PrimaryKeyTable, SequenceTable and UserDataTable so that they're always logged? they only contain metadata, which is updated infrequently or never, so logging them shouldn't be a performance issue.

other than that, lgtm, thanks!

@autodidacticon
Copy link
Contributor Author

a few of these tables are shared between different feature types - to avoid them being created differently depending on which feature type is created first, could you revert the changes to PartitionTablespacesTable, PrimaryKeyTable, SequenceTable and UserDataTable so that they're always logged? they only contain metadata, which is updated infrequently or never, so logging them shouldn't be a performance issue.

other than that, lgtm, thanks!

Done.

@elahrvivaz elahrvivaz merged commit f8b6dc7 into locationtech:main Dec 10, 2024
70 checks passed
@elahrvivaz
Copy link
Contributor

ty!

@autodidacticon autodidacticon deleted the unlogged-tables branch December 10, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants