Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should LPUSH return the length of the list? #85

Open
charleswhchan opened this issue May 20, 2015 · 3 comments
Open

Should LPUSH return the length of the list? #85

charleswhchan opened this issue May 20, 2015 · 3 comments

Comments

@charleswhchan
Copy link
Contributor

According to the official Redis LPUSH documentation:

Return value
Integer reply: the length of the list after the push operations.

When I use mockredis, the same function returns None.
@charleswhchan charleswhchan changed the title LPUSH does not return the length of the list, returns None instead Should LPUSH return the length of the list? May 22, 2015
@charleswhchan
Copy link
Contributor Author

Check redis-py client test case:
https://github.com/andymccurdy/redis-py/blob/81429b44acff3f238a212a1651241b49cde76c85/tests/test_commands.py#L640

Test indicates the function should return the queue length upon completion.

charleswhchan added a commit to charleswhchan/mockredis that referenced this issue May 24, 2015
@charleswhchan
CC - Fix issue locationlabs#85. Return length of list after LPUSH/RPU…
5e519b9 
…SH command.

See:
http://redis.io/commands/lpush
http://redis.io/commands/rpush
locationlabs#85
@charleswhchan charleswhchan mentioned this issue May 24, 2015
Merged
@charleswhchan
Copy link
Contributor Author

Anyone able to comment the issue / review the fix?

srikalyan added a commit that referenced this issue Nov 9, 2016
@srikalyan
Merge pull request #87 from charleswhchan/issue-85
aee12a8 
CC - Fix issue #85. Return length of list after LPUSH/RPUSH command.
@kblin
Copy link

kblin commented Dec 8, 2016

Now that this is merged, is it possible to get a new version with the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kblin @charleswhchan