add test for DeleteObjects encoding #9431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
1 task
bentsku
force-pushed
the
fix-s3-delete-objects-encoding
branch
from
b69f58b to
860d7f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #9428, there's an issue with the URL encoding of S3 object keys. This is an issue in moto, and it's working properly in our
v3provider.I have a PR open here: getmoto/moto#6933 but there's still some issue. This PR would only be green once the upstream fix is part of moto-ext, so I will
xfailit forv2until the PR is merged as it's a big change (it requires moto to useRAW_URIas well and change how to handle raw path with the update of werkzeug, they are manually re-encoding the path and it has some drawbacks for some edge cases like emoji), knowing thatv3is going to become default soon so I'd like to have it tested already now.Changes
Only introducing tests to validate the proper behaviour.