Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable model fetch for GitHub #4638

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

BrandonStudio
Copy link
Contributor

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Disable model fetch for GitHub.

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Fix #4547.

Copy link

vercel bot commented Nov 7, 2024

@BrandonStudio is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 7, 2024
@lobehubbot
Copy link
Member

๐Ÿ‘ @BrandonStudio

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@BrandonStudio
Copy link
Contributor Author

BrandonStudio commented Nov 7, 2024

Will db migration delete remoteModelCards automatically`?
Should we wait until #4260 merged?
@arvinxx

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 92.48%. Comparing base (bb4ab9c) to head (dd9da6e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #4638     +/-   ##
=========================================
  Coverage   92.48%   92.48%             
=========================================
  Files         511      511             
  Lines       36614    36614             
  Branches     2399     3538   +1139     
=========================================
  Hits        33862    33862             
  Misses       2752     2752             
Flag Coverage ฮ”
app 92.48% <100.00%> (รธ)
server 97.26% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Nov 7, 2024

Will db migration delete remoteModelCards automatically`?

no

Should we wait until #4260 merged?

no need

@arvinxx arvinxx merged commit e1f6a3a into lobehub:main Nov 7, 2024
6 of 8 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @BrandonStudio โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Nov 7, 2024
### [Version&nbsp;1.28.4](v1.28.3...v1.28.4)
<sup>Released on **2024-11-07**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Disable model fetch for GitHub.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Disable model fetch for GitHub, closes [#4638](#4638) ([e1f6a3a](e1f6a3a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.28.4 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Nov 7, 2024
### [Version&nbsp;1.71.2](v1.71.1...v1.71.2)
<sup>Released on **2024-11-07**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Disable model fetch for GitHub.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Disable model fetch for GitHub, closes [lobehub#4638](https://github.com/bentwnghk/lobe-chat/issues/4638) ([e1f6a3a](e1f6a3a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@BrandonStudio BrandonStudio deleted the patch-2 branch November 8, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "Get Model List" clears out Github models
3 participants