Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor(model): Deleting Deprecated Models #3208

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Jul 13, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

删除GeminiOpenAI已弃用模型

添加部分模型,修改部分连通性检测所使用的模型

Removed Gemini and OpenAI deprecated models

Add some models and modify some models used for connectivity detection

📝 补充信息 | Additional Information

Copy link

vercel bot commented Jul 13, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (d35c5b0) to head (dbc72c1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3208    +/-   ##
========================================
  Coverage   94.18%   94.18%            
========================================
  Files         396      396            
  Lines       24734    24755    +21     
  Branches     2697     1939   -758     
========================================
+ Hits        23295    23316    +21     
  Misses       1439     1439            
Flag Coverage Δ
app 94.18% <100.00%> (+<0.01%) ⬆️
server 68.29% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉还是等明确有废弃时间的,差不多等那个时候再变更比较合适。不然现在正在用的用户会叫的

src/config/modelProviders/openai.ts Show resolved Hide resolved
@RubuJam
Copy link
Contributor Author

RubuJam commented Jul 17, 2024

@arvinxx

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@arvinxx

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 6:11am

@arvinxx
Copy link
Contributor

arvinxx commented Jul 21, 2024

@RubuJam rebase 一下? 有冲突了

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@RubuJam rebase? There is a conflict

@RubuJam
Copy link
Contributor Author

RubuJam commented Jul 22, 2024

@arvinxx 处理完毕

Modification completed

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, Thanks for your contribution~

@arvinxx arvinxx merged commit ef54191 into lobehub:main Jul 22, 2024
7 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @RubuJam ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@RubuJam RubuJam deleted the Fix/model branch July 22, 2024 06:21
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
### [Version&nbsp;1.6.6](v1.6.5...v1.6.6)
<sup>Released on **2024-07-22**</sup>

#### ♻ Code Refactoring

- **model**: Clear and add models.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **model**: Clear and add models, closes [#3208](#3208) ([ef54191](ef54191))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.6.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 22, 2024
### [Version&nbsp;1.49.4](v1.49.3...v1.49.4)
<sup>Released on **2024-07-22**</sup>

#### ♻ Code Refactoring

- **model**: Clear and add models.

#### 🐛 Bug Fixes

- **misc**: Content lost unexpectedly on Qwen provider when `finish_reason` is `stop`.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **model**: Clear and add models, closes [lobehub#3208](https://github.com/bentwnghk/lobe-chat/issues/3208) ([ef54191](ef54191))

#### What's fixed

* **misc**: Content lost unexpectedly on Qwen provider when `finish_reason` is `stop`, closes [lobehub#3252](https://github.com/bentwnghk/lobe-chat/issues/3252) ([d35c5b0](d35c5b0))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.6.6](lobehub/lobe-chat@v1.6.5...v1.6.6)
<sup>Released on **2024-07-22**</sup>

#### ♻ Code Refactoring

- **model**: Clear and add models.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **model**: Clear and add models, closes [lobehub#3208](lobehub#3208) ([ef54191](lobehub@ef54191))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants