-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dang 123/Main vertical navigation #19
Conversation
…yling and behavior
In case there are some scenarios where we don't want to support collapsing nav (drawer animation) or nav items (toggling sub navs), add a prop that defaults to true so that we can choose to turn these features off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things here and there, but this looks so very pretty!
Mercedes and I talked about this privately, but for posterity: the expand/collapse functionality seems unideal to me, in that if the nav is full height, the only place you can really click to expand/collapse is to the left of child items (and how would a user know that?). Will put in our qs doc and flag for Shampa to add to LION's list.
<template> | ||
<li class="list-none"> | ||
<component | ||
:is="tag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is SO COOL! 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
JIRA
Description
Create an easily reusable and composable component for main vertical navigation.
Add a custom decorator for route-aware components in Storybook (there should be very few of these). This decorator does not play well with the Docs add-on due to
Vue.extend
but unfortunately that's the only way to add routing into a Storybook component since there's no other way to grab the Vue instance. We're manually telling the Docs addon what code to render for the source code examples to solve this.More info on using decorators to add context to stories here.
Navigation Features
to
prop or a button with a slot for the child items you want to compose inside of itTests
Things to note
@screen
directive. Because there are some animations and other styles that are not Tailwind-y and will not be reused, they are defined in the component styles themselves. They are also different between desktop and mobile so Tailwind's@screen
is super helpful to make sure we're using the breakpoints configured in the project with no variable duplication.Areas of Concern
GIFs/Memes
Reviewer Checklist
This section is to be filled out by reviewers
Testing