Use InDelta in TestExternallyControlledRun #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1677 +/- ##
==========================================
+ Coverage 72.10% 72.30% +0.20%
==========================================
Files 167 175 +8
Lines 12882 13443 +561
==========================================
+ Hits 9288 9720 +432
- Misses 3031 3115 +84
- Partials 563 608 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mstoykov
force-pushed
the
fixTestsAgain
branch
from
3784637 to
dd5817c
Compare
na--
previously approved these changes
Oct 20, 2020
mstoykov
changed the title
imiric
previously approved these changes
Oct 21, 2020
This is actually what should've been to begin with ... as k6 is trying to signal to the goja.VM that it should stop because the context was canceled (or the deadline was reached). Previous to this there was the chance that the goja.VM will be in a call that will throw the context.Canceled on it's own (sleep) if the context was canceled. Fixes #1485
mstoykov
force-pushed
the
fixTestsAgain
branch
from
d02f979 to
2d967ab
Compare
na--
reviewed
Oct 23, 2020
mstoykov
force-pushed
the
fixTestsAgain
branch
from
2d967ab to
8ec265e
Compare
|
I added this to the v0.29.0 milestone, since it fixes the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.