Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into whether we should rename "context cancelled" #1485

Closed
mstoykov opened this issue Jun 4, 2020 · 2 comments
Closed

Look into whether we should rename "context cancelled" #1485

mstoykov opened this issue Jun 4, 2020 · 2 comments
Labels
bug evaluation needed proposal needs to be validated or tested before fully implementing it in k6 tests
Milestone

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Jun 4, 2020

In the js package we have an errInterrupted it is used to signal that we interrupted the iteratiosn. Unfortunately sometimes we get "context canceled"(one l not two) which is from when a context gets canceled

=== RUN   TestVURunInterruptDoesntPanic/Archive
    TestVURunInterruptDoesntPanic/Archive: assertions.go:247: ^M                          ^M    Error Trace:    runner_test.go:625
        ^M                      ^M                      asm_amd64.s:1373
        ^M      Error:          "context canceled" does not contain "context cancelled"
        ^M      Test:           TestVURunInterruptDoesntPanic/Archive
--- FAIL: TestVURunInterruptDoesntPanic (10.22s)

This seems like a slight race .. but ultimately I think it doesn't matter it will just be better if we make ours be single l as well but this needs more investigation I think :D

@mstoykov mstoykov added bug tests evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Jun 4, 2020
@na--
Copy link
Member

na-- commented Jun 4, 2020

is anything going to break if we fix the spelling of our error? if not, we should just do it :)

@mstoykov
Copy link
Contributor Author

mstoykov commented Jun 4, 2020

No idea, no time to check it all .. just I got it the second time today and decided to write it down while not trying to fix that as well :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug evaluation needed proposal needs to be validated or tested before fully implementing it in k6 tests
Projects
None yet
Development

No branches or pull requests

2 participants