Remove support for node v14, v16 and v18 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screendriver
approved these changes
Feb 16, 2024
mdmower-csnw
reviewed
Mar 8, 2024
| @@ -3,7 +3,7 @@ | |||
| "version": "10.3.0", | |||
| "description": "Eslint rules for mocha.", | |||
| "engines": { | |||
| "node": ">=14.0.0" | |||
| "node": ">=20.0.0" | |||
There was a problem hiding this comment.
@lo1tuma - this implies that "eslint-plugin-mocha will only work on Node.js 20+", right? are you really cutting off support for Node 18 which is supported until April/May 2025? If so, shouldn't this have been introduced as a breaking change (i.e. major version bumped to 11 and a notice added to release notes)?
There was a problem hiding this comment.
This change hasn’t been released yet. I’m aware that this is a breaking change and it will land in a new major version.
For people who still need node versions < 20 I recommend using eslint-plugin-mocha 10.x. If there are any critical bugs I’m happy to backport them to v10 and make new patch releases as long as node v18 is around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.