Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove autofix from no-skipped-tests rule fix #258

Merged
merged 2 commits into from
Jul 31, 2020

Conversation

LukaPrebil
Copy link

@LukaPrebil LukaPrebil commented Jul 28, 2020

Remove autofix from rule no-skipped-tests as it alters the test runtime, and makes it impossible to use this rule as a warning
resolves #242

@LukaPrebil LukaPrebil force-pushed the no-skipped-tests-remove-autofix branch from 5dd91af to b82ee43 Compare July 28, 2020 07:23
@LukaPrebil LukaPrebil changed the title #242 remove autofix from no-skipped-tests rule remove autofix from no-skipped-tests rule fix #242 Jul 28, 2020
@LukaPrebil LukaPrebil changed the title remove autofix from no-skipped-tests rule fix #242 remove autofix from no-skipped-tests rule fix Jul 28, 2020
@LukaPrebil LukaPrebil marked this pull request as ready for review July 28, 2020 07:26
@LukaPrebil
Copy link
Author

@lo1tuma is this project still active, and if so, could you check this out?

@lo1tuma
Copy link
Owner

lo1tuma commented Jul 31, 2020

@Luka-PG yes, this project is still active but since I’m maintaining it in my spare time I’m not able to look at it every day.

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@lo1tuma lo1tuma merged commit 8823b33 into lo1tuma:master Jul 31, 2020
@LukaPrebil
Copy link
Author

Great, thanks for merging!

@Renatopster
Copy link

Are there any plans of a new release in the near future?

@lo1tuma
Copy link
Owner

lo1tuma commented Aug 6, 2020

It is published in v8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-skipped-tests should not be autofixable
3 participants