Fix prefer-arrow-callback to not fail when using import.meta

lo1tuma · Aug 8, 2020 · efafb46 · efafb46
1 parent 08f399a
commit efafb46
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/lib/rules/prefer-arrow-callback.js b/lib/rules/prefer-arrow-callback.js
@@ -27,6 +27,17 @@ function isFunctionName(variable) {
     return variable && variable.defs[0].type === 'FunctionName';
 }
 
+/**
+ * Checks whether or not a given MetaProperty node equals to a given value.
+ * @param {ASTNode} node - A MetaProperty node to check.
+ * @param {string} metaName - The name of `MetaProperty.meta`.
+ * @param {string} propertyName - The name of `MetaProperty.property`.
+ * @returns {boolean} `true` if the node is the specific value.
+ */
+function checkMetaProperty(node, metaName, propertyName) {
+    return node.meta.name === metaName && node.property.name === propertyName;
+}
+
 /**
  * Gets the variable object of `arguments` which is defined implicitly.
  * @param {eslint-scope.Scope} scope - A scope to get.
@@ -228,10 +239,12 @@ module.exports = {
                 }
             },
 
-            MetaProperty() {
+            MetaProperty(node) {
                 const info = stack[stack.length - 1];
 
-                info.meta = true;
+                if (info && checkMetaProperty(node, 'new', 'target')) {
+                    info.meta = true;
+                }
             },
 
             // To skip nested scopes.

diff --git a/test/rules/prefer-arrow-callback.js b/test/rules/prefer-arrow-callback.js
@@ -43,6 +43,13 @@ ruleTester.run('prefer-arrow-callback', rules['prefer-arrow-callback'], {
         'foo(function bar() { new.target; });',
         'foo(function bar() { new.target; }.bind(this));',
         'foo(function bar() { this; }.bind(this, somethingElse));',
+        {
+            code: 'import.meta.url',
+            parserOptions: {
+                ecmaVersion: 2020,
+                sourceType: 'module'
+            }
+        },
         // mocha-specific valid test cases
         'before(function bar() {});',
         'after(function bar() {});',