Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aggregation destroying unrelated stuff + terrible performance #236

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Fix aggregation destroying unrelated stuff + terrible performance #236

merged 6 commits into from
Mar 1, 2024

Conversation

DanielJackson-Oslo
Copy link
Member

This branch does two things:

  • Tests and fixes a bug where changing the description of a facility (but not setting an experience for it) would delete all descriptions of other facilities.
  • Increases the performance of review aggregation 10x, from a median of 200ms on my machine to a median of 10-20ms.

@DanielJackson-Oslo DanielJackson-Oslo merged commit 8726acb into main Mar 1, 2024
1 check passed
@DanielJackson-Oslo DanielJackson-Oslo deleted the fix-aggregation-destroying-unrelated-stuff branch March 1, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanielJackson-Oslo