Auto merge of rust-lang#12967 - jhgg:code/fix-toggle-hints, r=Veykril

[code] make toggleInlayHints understand {off,on}UntilPressed fixes rust-lang#12964
lnicola · Aug 8, 2022 · 49700e4 · 49700e4
2 parents 20d6441 + 4b648d8
commit 49700e4
Showing 1 changed file with 16 additions and 2 deletions.
diff --git a/editors/code/src/commands.ts b/editors/code/src/commands.ts
@@ -326,8 +326,22 @@ export function toggleInlayHints(_ctx: Ctx): Cmd {
         const config = vscode.workspace.getConfiguration("editor.inlayHints", {
             languageId: "rust",
         });
-        const value = !config.get("enabled");
-        await config.update("enabled", value, vscode.ConfigurationTarget.Global);
+
+        const value = config.get("enabled");
+        let stringValue;
+        if (typeof value === "string") {
+            stringValue = value;
+        } else {
+            stringValue = value ? "on" : "off";
+        }
+        const nextValues: Record<string, string> = {
+            on: "off",
+            off: "on",
+            onUnlessPressed: "offUnlessPressed",
+            offUnlessPressed: "onUnlessPressed",
+        };
+        const nextValue = nextValues[stringValue] ?? "on";
+        await config.update("enabled", nextValue, vscode.ConfigurationTarget.Global);
     };
 }