forked from graasp/graasp-auth
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6 update layout - update colors, change logos #7
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
db4a1c2
feat: updates to layout for lnco graasp and prettier run
ymijsters baa9b36
fix: update colors in fullscreen container
ymijsters 4dd8ab8
fix: update some wording on data-driven content and error messages
ymijsters 0c1df1c
fix: remove references to Graasp from translations
ymijsters 19476e9
fix: remove unnecessary style tag
ymijsters 2613d80
fix: update package version and add color constant
ymijsters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ name: Release new app version | |
on: | ||
push: | ||
branches: | ||
- "main" | ||
- 'main' | ||
|
||
permissions: | ||
contents: write | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,10 +2,10 @@ import React, { FC, useState } from 'react'; | |
import { Link, useLocation } from 'react-router-dom'; | ||
|
||
import { RecaptchaAction } from '@graasp/sdk'; | ||
import { Button, GraaspLogo } from '@graasp/ui'; | ||
import { Button } from '@graasp/ui'; | ||
|
||
import { LoadingButton } from '@mui/lab'; | ||
import { Stack, useTheme } from '@mui/material'; | ||
import { Stack } from '@mui/material'; | ||
import Box from '@mui/material/Box'; | ||
import FormControl from '@mui/material/FormControl'; | ||
import Typography from '@mui/material/Typography'; | ||
|
@@ -46,7 +46,6 @@ const { | |
const SignIn: FC = () => { | ||
const { t } = useAuthTranslation(); | ||
const { executeCaptcha } = useRecaptcha(); | ||
const theme = useTheme(); | ||
|
||
const { isMobile, challenge } = useMobileAppLogin(); | ||
const { search } = useLocation(); | ||
|
@@ -270,11 +269,13 @@ const SignIn: FC = () => { | |
) : ( | ||
<Stack direction="column" alignItems="center" spacing={2}> | ||
<Stack spacing={1}> | ||
<GraaspLogo | ||
height={90} | ||
sx={{ fill: theme.palette.primary.main }} | ||
/> | ||
<Typography variant="h4" component="h2" id={SIGN_IN_HEADER_ID}> | ||
<img alt="LNCO Logo" height="200" src="/lnco-logo.png" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would try to include this as an SVG component. |
||
<Typography | ||
variant="h4" | ||
component="h2" | ||
id={SIGN_IN_HEADER_ID} | ||
sx={{ textAlign: 'center' }} | ||
> | ||
{t(SIGN_IN_HEADER)} | ||
</Typography> | ||
</Stack> | ||
|
@@ -285,6 +286,7 @@ const SignIn: FC = () => { | |
disabled={signInMethod === SIGN_IN_METHODS.EMAIL} | ||
onClick={handleSignInMethod} | ||
id={EMAIL_SIGN_IN_METHOD_BUTTON_ID} | ||
color={'primary'} | ||
> | ||
{t(EMAIL_SIGN_IN_METHOD)} | ||
</Button> | ||
|
@@ -293,6 +295,7 @@ const SignIn: FC = () => { | |
disabled={signInMethod === SIGN_IN_METHODS.PASSWORD} | ||
onClick={handleSignInMethod} | ||
id={PASSWORD_SIGN_IN_METHOD_BUTTON_ID} | ||
color={'primary'} | ||
> | ||
{t(PASSWORD_SIGN_IN_METHOD)} | ||
</Button> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,10 +6,9 @@ import { | |
MIN_USERNAME_LENGTH, | ||
RecaptchaAction, | ||
} from '@graasp/sdk'; | ||
import { GraaspLogo } from '@graasp/ui'; | ||
|
||
import { LoadingButton } from '@mui/lab'; | ||
import { FormControl, LinearProgress, Stack, useTheme } from '@mui/material'; | ||
import { FormControl, LinearProgress, Stack } from '@mui/material'; | ||
import Typography from '@mui/material/Typography'; | ||
|
||
import { useAuthTranslation } from '../config/i18n'; | ||
|
@@ -46,7 +45,6 @@ const { | |
const SignUp = () => { | ||
const { t, i18n } = useAuthTranslation(); | ||
const { executeCaptcha } = useRecaptcha(); | ||
const theme = useTheme(); | ||
|
||
const { isMobile, challenge } = useMobileAppLogin(); | ||
const redirect = useRedirection(); | ||
|
@@ -160,9 +158,9 @@ const SignUp = () => { | |
} | ||
|
||
return ( | ||
<Stack direction="column" spacing={2}> | ||
<Stack direction="column" alignItems="center" spacing={2}> | ||
<Stack spacing={1}> | ||
<GraaspLogo height={90} sx={{ fill: theme.palette.primary.main }} /> | ||
<img alt="LNCO Logo" height="200" src="/lnco-logo.png" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above. |
||
<Typography | ||
variant="h4" | ||
component="h2" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export const MAX_CHECKBOX_LABEL_WITH_PX_SIGN_UP = 330; | ||
export const AUTH_BOX_BORDER_AND_SHADOW_COLOR = 'rgba(40,40,40,0.4)'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do you think we can have an SVG version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's definitely not very simple, I will try one more approach myself today otherwise we will have to ask around. I would suggest for now that this is not a blocker for this PR.