fix: add notifier for non existent password

lnco-epfl · Mar 28, 2022 · bcd10da · bcd10da
1 parent 0ed58de
commit bcd10da
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/src/actions/authentication.js b/src/actions/authentication.js
@@ -10,6 +10,7 @@ import {
   SIGN_UP_DUPLICATE,
   SIGN_IN_PASSWORD_INVALID,
   SIGN_IN_PASSWORD_SUCCESS,
+  SIGN_IN_PASSWORD_NON_EXISTENT,
 } from '../types/member';
 import notifier from '../utils/notifier';
 
@@ -45,6 +46,8 @@ export const signInPassword = async (payload) => {
   } catch (error) {
     if (error.response.status === StatusCodes.UNAUTHORIZED) {
       notifier.error({ code: SIGN_IN_PASSWORD_INVALID, error });
+    } else if (error.response.status === StatusCodes.NOT_ACCEPTABLE) {
+      notifier.error({ code: SIGN_IN_PASSWORD_NON_EXISTENT, error });
     } else {
       notifier.error({ code: SIGN_IN_INVALID, error });
     }

diff --git a/src/config/messages.js b/src/config/messages.js
@@ -8,6 +8,8 @@ export const SIGN_IN_INVALID_PASSWORD_MESSAGE =
   'Incorrect password. Please try again.';
 export const SIGN_IN_SUCCESS_PASSWORD_MESSAGE =
   'Correct password. You successfully signed in.';
+export const SIGN_IN_NON_EXISTENT_PASSWORD_MESSAGE =
+  'This user does not have a password set. Please use email sign in.';
 export const SIGN_UP_ERROR_MESSAGE = 'There was an error signing up.';
 export const SIGN_UP_DUPLICATE_MESSAGE =
   'This user already exists. Please sign in.';

diff --git a/src/types/member.js b/src/types/member.js
@@ -10,6 +10,7 @@ export const SIGN_IN_INVALID = 'SIGN_IN_INVALID';
 export const SIGN_IN_ERROR = 'SIGN_IN_ERROR';
 export const SIGN_IN_PASSWORD_SUCCESS = 'SIGN_IN_PASSWORD_SUCCESS';
 export const SIGN_IN_PASSWORD_INVALID = 'SIGN_IN_PASSWORD_INVALID';
+export const SIGN_IN_PASSWORD_NON_EXISTENT = 'SIGN_IN_PASSWORD_NON_EXISTENT';
 export const SIGN_IN_PASSWORD_ERROR = 'SIGN_IN_PASSWORD_ERROR';
 export const SIGN_UP_DUPLICATE = 'SIGN_UP_DUPLICATE';
 export const SIGN_UP_SUCCESS = 'SIGN_UP_SUCCESS';

diff --git a/src/utils/notifier.js b/src/utils/notifier.js
@@ -10,11 +10,13 @@ import {
   SIGN_UP_DUPLICATE_MESSAGE,
   SIGN_UP_ERROR_MESSAGE,
   SIGN_UP_SUCCESS_MESSAGE,
+  SIGN_IN_NON_EXISTENT_PASSWORD_MESSAGE,
 } from '../config/messages';
 import {
   SIGN_IN_ERROR,
   SIGN_IN_INVALID,
   SIGN_IN_PASSWORD_INVALID,
+  SIGN_IN_PASSWORD_NON_EXISTENT,
   SIGN_IN_PASSWORD_SUCCESS,
   SIGN_IN_SUCCESS,
   SIGN_UP_DUPLICATE,
@@ -42,6 +44,10 @@ const notifier = {
         message = SIGN_IN_SUCCESS_PASSWORD_MESSAGE;
         break;
       }
+      case SIGN_IN_PASSWORD_NON_EXISTENT: {
+        message = SIGN_IN_NON_EXISTENT_PASSWORD_MESSAGE;
+        break;
+      }
       case SIGN_IN_ERROR: {
         message = SIGN_IN_ERROR_MESSAGE;
         break;