shfmt -p (reformat in posix mode) #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But travis happens after commits. I'm not sure what's the question. Locally you can add it to your git hooks - see If that software has a check mode, you can also add it to the |
meeDamian
reviewed
Apr 30, 2019
| /bin/mkdir /media/sd && \ | ||
| /bin/mount /media/sd | ||
| echo "Create and mount ext4 filesystem" | ||
| /sbin/mkfs.ext4 -F /dev/${SD}p2 && |
There was a problem hiding this comment.
Yyyyyy… Are you sure that the removal of the slashes here doesn't break the code?
|
It removed all trailing slashes everywhere. I would guess it breaks the code, no? |
@meeDamian I’ll check before merging. Maybe the && counts as a line continuation? |
|
This might be useful but can we salvage some of this or close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shfmt brings automated formatting to shell, and is written in golang
@meeDamian What is the best way to add this to Travis, to ensure it gets run before every commit?