Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix tip rounding #77

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Hotfix tip rounding #77

merged 2 commits into from
Apr 8, 2024

Conversation

talvasconcelos
Copy link
Collaborator

@talvasconcelos talvasconcelos commented Mar 29, 2024

Prevent the event listener when setting tip rounding

Closes #76

remove event listener when setting tip
@@ -806,9 +806,6 @@ <h5 class="q-mt-none q-mb-sm">
totalfsat: function () {
return LNbits.utils.formatSat(this.totalSat)
},
isRoundValid() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function was not used at all?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems it wasn't

@talvasconcelos talvasconcelos merged commit 66a28c0 into main Apr 8, 2024
@talvasconcelos talvasconcelos deleted the fix_round_tip_behaviour branch April 8, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rounding in Tip Section leads to weird behaviour
4 participants