Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Exit ATM MODE" from rectangle to button #68

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

tlindi
Copy link
Contributor

@tlindi tlindi commented Feb 14, 2024

Proposal for more streamlined visuals for ATM mode

Current legend tpos-ATM mode
image

PR provided tpos ATM mode
image

@tlindi
Copy link
Contributor Author

tlindi commented Feb 26, 2024

Comments?

Could/should withdraw currence values be shown prefix "-" and color "negative"? But that would be another issue & PR.

@talvasconcelos talvasconcelos requested a review from prusnak March 6, 2024 09:54
v-if="atmMode"
rounded
color="negative"
>ATM MODE</div
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your idea. I just think it's no so obvious that the button exits the ATM mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "EXIT ATM" be more clear?

This whole botton would not be need if value had negative color, and - sign on ATM mode and ATM button color presenting the mode IMHO.

@prusnak
Copy link
Collaborator

prusnak commented Mar 6, 2024

Which of these two red buttons exit the ATM mode?

Screenshot 2024-03-06 at 11 19 24

Only top, only right, both?

I suggest we use only one element and drop the other one. Maybe if the button on the right disappeared when the ATM mode is active, it would make it less confusing?

@tlindi
Copy link
Contributor Author

tlindi commented Mar 6, 2024

Both. Disappearing button would be easy and works for me. Decision?

@tlindi tlindi requested a review from talvasconcelos March 6, 2024 11:21
@tlindi tlindi force-pushed the Streamline-EXIT-ATM-button branch 2 times, most recently from 7be7286 to dd46fd5 Compare March 13, 2024 20:53
@tlindi
Copy link
Contributor Author

tlindi commented Mar 13, 2024

Which of these two red buttons exit the ATM mode?

Screenshot 2024-03-06 at 11 19 24 Only top, only right, both?

I suggest we use only one element and drop the other one. Maybe if the button on the right disappeared when the ATM mode is active, it would make it less confusing?

did it. Look clean to me.

LNbits.-.tpos.0.6.2-tlindi.mp4

@tlindi tlindi force-pushed the Streamline-EXIT-ATM-button branch from dd46fd5 to bc8d35e Compare March 13, 2024 21:16
@tlindi
Copy link
Contributor Author

tlindi commented Mar 13, 2024

includes workaround for #74

@tlindi tlindi force-pushed the Streamline-EXIT-ATM-button branch from bc8d35e to 1366a57 Compare March 15, 2024 21:50
@tlindi tlindi changed the title "Exit ATM MODE" function to "ATM" Button Change "Exit ATM MODE" from rectangle to button Mar 20, 2024
@talvasconcelos talvasconcelos requested review from dni and motorina0 March 29, 2024 12:00
templates/tpos/tpos.html Outdated Show resolved Hide resolved
and add hide ATM button when in ATM mode
@tlindi tlindi force-pushed the Streamline-EXIT-ATM-button branch from 1366a57 to 96da7c5 Compare March 29, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants