-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functionality to add on TPoS #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to make a seperate commit for formatting next time :) as it is easier to review.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Orange and Red colors are the other way around (DEL should be yellow since it deletes only 1 char, C should be red since it deletes all). I think we should also swap positions of DEL and C (so C is left and DEL is right). Ideally also replace "DEL" with back arrow symbol (← or ⬅).
- Plus functionality behaves super confusing - the OK should be always OK, the plus should be always +.
- There is a merge conflict now.
I addressed my concerns above in my branch My branch is still just the UI prototype to show how I think the UI should work. Submitting the form still needs fixing (it should pickup |
e051eab
to
0ac601d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ACK
Can we get this merged on main? I need to work on something on top of it! |
You have to resolve conflicts with main first (ideally with |
i don't see conflicts... |
Because you did not pull main?
|
Ah, OK. Sorry. Squashing is possible via UI, rebasing via UI is not. Let's go and merge via squash! 👍 |
Closes #28, closes #29