Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx TPoS looking for removed lnbits_commit hash #22

Merged
merged 2 commits into from
Oct 6, 2023
Merged

FIx TPoS looking for removed lnbits_commit hash #22

merged 2 commits into from
Oct 6, 2023

Conversation

gorrdy
Copy link
Contributor

@gorrdy gorrdy commented Oct 5, 2023

fix tpos not working in some cases due to missing lnbits_commit in settings

not sure if the commit version in header is even important - probably not.

fix tpos not working in some cases due to missing lnbits_commit in settings
@gorrdy gorrdy changed the title Update views_api.py FIx TPoS looking for removed lnbits_commit hash Oct 5, 2023
Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@prusnak
Copy link
Collaborator

prusnak commented Oct 5, 2023

@talvasconcelos we should merge this PR, release tpos-0.4.3 and update it in https://github.com/lnbits/lnbits-extensions ASAP

Copy link
Contributor

@iWarpBTC iWarpBTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the import at the line 19 can be deleted in this case.
from lnbits.settings import settings

@dni dni requested review from iWarpBTC and dni and removed request for iWarpBTC October 6, 2023 07:16
@dni dni merged commit 759d9ee into lnbits:main Oct 6, 2023
@dni
Copy link
Member

dni commented Oct 6, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants