Skip to content

Commit

Permalink
aspnet.server.unhandled_requests -> aspnet.unhandled_requests
Browse files Browse the repository at this point in the history
  • Loading branch information
lmolkova committed Jul 26, 2023
1 parent 4d67e5e commit 7873394
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions docs/dotnet/dotnet-aspnet-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This document defines semantic conventions for ASP.NET Core metrics, not specifi
<!-- toc -->

- [Server](#server)
* [Metric: `aspnet.server.unhandled_requests`](#metric-aspnetserverunhandled_requests)
* [Metric: `aspnet.unhandled_requests`](#metric-aspnetunhandled_requests)
- [Routing](#routing)
* [Metric: `aspnet.routing.successful_matches`](#metric-aspnetroutingsuccessful_matches)
- [Exception metrics](#exception-metrics)
Expand All @@ -25,19 +25,19 @@ This document defines semantic conventions for ASP.NET Core metrics, not specifi

## Server

### Metric: `aspnet.server.unhandled_requests`
### Metric: `aspnet.unhandled_requests`

**TODO:Any chance we will need to report any attributes in future?**

<!-- semconv metric.aspnet.server.unhandled_requests(metric_table) -->
<!-- semconv metric.aspnet.unhandled_requests(metric_table) -->
| Name | Instrument Type | Unit (UCUM) | Description |
| -------- | --------------- | ----------- | -------------- |
| `aspnet.server.unhandled_requests` | UpDownCounter | `{request}` | Number of requests that reached the end of the middleware pipeline without being handled by application code. [1] |
| `aspnet.unhandled_requests` | UpDownCounter | `{request}` | Number of requests that reached the end of the middleware pipeline without being handled by application code. [1] |

**[1]:** Meter name is `Microsoft.AspNetCore.Hosting`.
<!-- endsemconv -->

<!-- semconv metric.aspnet.server.unhandled_requests(full) -->
<!-- semconv metric.aspnet.unhandled_requests(full) -->
<!-- endsemconv -->

## Routing
Expand Down
4 changes: 2 additions & 2 deletions model/metrics/dotnet-aspnet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ groups:
- ref: server.port
note: "**TODO: this is opt-in in otel, i.e. it needs explicit configuration option to be reported**"

- id: metric.aspnet.server.unhandled_requests
- id: metric.aspnet.unhandled_requests
type: metric
metric_name: aspnet.server.unhandled_requests
metric_name: aspnet.unhandled_requests
brief: Number of requests that reached the end of the middleware pipeline without being handled by application code.
instrument: updowncounter
unit: "{request}"
Expand Down

0 comments on commit 7873394

Please sign in to comment.