Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, again, @lmirosevic!
Figured I'd toss up a PR, adding the new iPads, now that you've landed the new naming.
Heads up that Apple may have added "-A", "-B" suffixes of the model identifiers of new iPad Pros, e.g., "iPad14,3-A". Apple's legal URLs don't show it (https://www.apple.com/legal/rfexposure/ipad14,6/en/), nor does everymac.com, but this Gist does.
Either way, I think we're fine and good to merge. I think your implementation of _deviceVersion will happily ignore the suffix, since it uses integerValue.
Still, though, it's something to keep an eye on in case it becomes common. I've commented back on the gist to ask. But if you know of a more authoratative source for iPad model identifiers, I'd love it if you'd share it with me!
-Chris