Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add late 2022 iPads #139

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Add late 2022 iPads #139

merged 1 commit into from
Oct 26, 2022

Conversation

cpsauer
Copy link
Collaborator

@cpsauer cpsauer commented Oct 26, 2022

Hello, again, @lmirosevic!

Figured I'd toss up a PR, adding the new iPads, now that you've landed the new naming.

Heads up that Apple may have added "-A", "-B" suffixes of the model identifiers of new iPad Pros, e.g., "iPad14,3-A". Apple's legal URLs don't show it (https://www.apple.com/legal/rfexposure/ipad14,6/en/), nor does everymac.com, but this Gist does.

Either way, I think we're fine and good to merge. I think your implementation of _deviceVersion will happily ignore the suffix, since it uses integerValue.

Still, though, it's something to keep an eye on in case it becomes common. I've commented back on the gist to ask. But if you know of a more authoratative source for iPad model identifiers, I'd love it if you'd share it with me!

-Chris

@lmirosevic lmirosevic merged commit 2a38aa0 into lmirosevic:master Oct 26, 2022
@lmirosevic
Copy link
Owner

Cut a new release for this: 7.1.0

@cpsauer
Copy link
Collaborator Author

cpsauer commented Nov 9, 2022

BTW, folks have confirmed that the new iPads stick with the consistent naming scheme and don't have the -A and -B suffixes that Xcode might have indicated. Yay for simplicity and consistency. One less thing to worry about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants