Update unumpy test to be compatible with numpy 2 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uncertainties` defines error-propagating versions of several of the functions in the `math` module. Then in the `unumpy` code, it iterates over this same set and defines array-compatible versions of those functions using `numpy.vectorize`. Because before numpy 2 numpy used different names for the inverse trigonometric functions (`arccos` vs `acos`), the code needed to change the name for the numpy version. One place in the tests just checked that `arccos` was in the numpy module and `acos` was not. Since numpy 2 added the aliases for the `a`-named versions of the `arc` functions, that test fails with numpy 2. Since `uncertainties` does not really need to test the names of functions in `numpy` that check is removed. A future update could add the `acos()`-style aliases to `unumpy` as well.
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 95.74% 95.74% -0.01%
==========================================
Files 12 12
Lines 1905 1904 -1
==========================================
- Hits 1824 1823 -1
Misses 81 81 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncertaintiesdefines error-propagating versions of several of the functions in themathmodule. Then in theunumpycode, it iterates over this same set and defines array-compatible versions of those functions usingnumpy.vectorize. Because before numpy 2 numpy used different names for the inverse trigonometric functions (arccosvsacos), the code needed to change the name for the numpy version. One place in the tests just checked thatarccoswas in the numpy module andacoswas not. Since numpy 2 added the aliases for thea-named versions of thearcfunctions, that test fails with numpy 2. Sinceuncertaintiesdoes not really need to test the names of functions innumpythat check is removed.A future update could add the
acos()-style aliases tounumpyas well.