Update ConfidenceInterval class constructor parameters #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defining `self.min_rel_change` in confidence.py as variable Fixes lmfit#936
|
I fully agree with addition. I think a test showing that changing the parameter does something useful would be nice. |
|
@Anselmoo Thanks -- I agree with this being better as a command-line argument. So, Yes, Thanks! I'm not sure I understand all the test failures, but bear with us as we try to figure out what is causing them. |
reneeotten
requested changes
Jan 24, 2024
…l class According to review, set to the end of the functions Fix formatting in conf_interval function
reneeotten
requested changes
Jan 25, 2024
There was a problem hiding this comment.
thanks @Anselmoo ; it looks like that correcting the position of the new argument fixed the tests as well. This looks good to me, except for a few changes that are required in the docstring.
|
@Anselmoo Thanks - that looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining
self.min_rel_changein confidence.py as variable Fixes #936Description
This pull request updates the constructor parameters of the ConfidenceInterval class in
confidence.py. Specifically, it adds a new parameter calledmin_rel_changewith a default value of 1e-5. This change addresses issue #936.Type of Changes
Tested on
Verification
Have you