Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(repo): Cachable Yarn installs #1554

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Chore(repo): Cachable Yarn installs #1554

merged 1 commit into from
Sep 13, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Jul 19, 2024

Description

Enabling cache while setting up Node environment. The setup-node action added new feature with Yarn caching.

Bahmutovs/npm-install still lacks the support for Yarn Modern.

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1402

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Jul 19, 2024
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c5fd8b5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e3fc77b40bbe00086f203d
😎 Deploy Preview https://deploy-preview-1554--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit c5fd8b5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e3fc77ced7ed000884bd2e
😎 Deploy Preview https://deploy-preview-1554--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 11, 2024

Coverage Status

coverage: 78.696%. remained the same
when pulling c5fd8b5 on chore/yarn-state-file
into 186261a on main.

@literat literat changed the title Chore(repo): Introduce Yarn plugin for overriding state Chore(repo): Cachable Yarn installs Sep 11, 2024
@literat
Copy link
Collaborator Author

literat commented Sep 11, 2024

With the cache only about 30s of the installation time.

Screenshot 2024-09-11 at 17 17 00

@literat literat force-pushed the chore/yarn-state-file branch 2 times, most recently from 92534cc to f59e3cb Compare September 11, 2024 15:39
@literat literat marked this pull request as ready for review September 11, 2024 15:40
@literat literat requested a review from a team as a code owner September 11, 2024 15:40
.github/workflows/e2e.yml Show resolved Hide resolved
  * it appears that the caching ability of the library is broken
  * @see: bahmutov/npm-install#146

fixes #DS-1402
@literat literat merged commit e5c8a7b into main Sep 13, 2024
14 checks passed
@literat literat deleted the chore/yarn-state-file branch September 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants