Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor builder pattern for ClientBuilder #3

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

lmammino
Copy link
Owner

  • Allows proper chaining of methods
  • simplify types by internally storing username and api_key as Strings and only accept AsRef<str> in the constructors
  • have from_env and try_from_env methods also in ClientBuilder()

@lmammino lmammino merged commit 836f4ee into main Apr 24, 2023
@lmammino lmammino deleted the refactor-builder-pattern branch April 24, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant