Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bazel] Run buildifier #1250

Merged
merged 2 commits into from
Aug 19, 2022
Merged

[Bazel] Run buildifier #1250

merged 2 commits into from
Aug 19, 2022

Conversation

sjain-stanford
Copy link
Member

@sjain-stanford sjain-stanford commented Aug 19, 2022 •
edited
Loading

Lint all Bazel files (BUILD, WORKSPACE, .bzl, or .sky).

Steps followed:

./utils/bazel/run_docker.sh

# run within container
git clone https://github.com/bazelbuild/buildtools.git
cd buildtools
bazel build //buildifier
# buildifier formatter
./bazel-bin/buildifier/buildifier_/buildifier -r ../utils/bazel/
# buildifier linter
./bazel-bin/buildifier/buildifier_/buildifier --lint=fix -r ../utils/bazel/

@sjain-stanford
Copy link
Member Author

sjain-stanford commented Aug 19, 2022 •
edited
Loading

GHA workflow green: https://github.com/sjain-stanford/torch-mlir/runs/7911126770?check_suite_focus=true

@sjain-stanford sjain-stanford merged commit 1e1759c into llvm:main Aug 19, 2022
@tanyokwok tanyokwok mentioned this pull request Sep 21, 2022
Closed
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
@tungld
Use builder based interface to generate Krnl loops (llvm#1250)
f8f0a1e 
* [ClipOp]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <[email protected]>

* [TileOp]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <[email protected]>

* [Transpose]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <[email protected]>

* [Transpose]: Remove #ifdef out code

Signed-off-by: Ettore Tiotto <[email protected]>

* [Split]: Use builder based interface to generate Krnl loops

Signed-off-by: Ettore Tiotto <[email protected]>

* Address code review comments

Signed-off-by: Ettore Tiotto <[email protected]>

Co-authored-by: Tung D. Le <[email protected]>
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
@whitneywhtsang
Remove BuildKrnlLoop (llvm#1410)
0cb5427 
The modification to use the builder based interface to generate Krnl loop is completed (llvm#1250, llvm#1283, llvm#1285, llvm#1292, llvm#1293, llvm#1303, llvm#1308, llvm#1314, llvm#1316, llvm#1317, llvm#1326, llvm#1403), and BuildKrnlLoop is no longer needed.

Signed-off-by: Whitney Tsang [email protected]
@sjain-stanford sjain-stanford deleted the sambhav/buildifier branch November 15, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaadaldien asaadaldien Awaiting requested review from asaadaldien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjain-stanford