Fix unused-variables warnings about EmbeddingBag ops #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
force-pushed
the
fix-warnings-embedding
branch
from
549a5a4
to
445585c
Compare
vidsinghal
reviewed
Aug 13, 2022
According to the documentation for `torch.embedding_bag` (https://pytorch.org/docs/stable/generated/torch.nn.functional.embedding_bag.html), the default value for `scale_grad_by_freq` is False.
ramiro050
force-pushed
the
fix-warnings-embedding
branch
from
445585c
to
7d5d068
Compare
I was checking for |
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
* draft Signed-off-by: chentong319 <[email protected]> * move type converter Signed-off-by: chentong319 <[email protected]> * lowering Signed-off-by: chentong319 <[email protected]> * new Cast interface Signed-off-by: chentong319 <[email protected]> * more verify and shape Signed-off-by: chentong319 <[email protected]> * add warning Signed-off-by: chentong319 <[email protected]> * allow Seq type Signed-off-by: chentong319 <[email protected]> * pass runtime test Signed-off-by: chentong319 <[email protected]> * rm SequenceConstruct Signed-off-by: chentong319 <[email protected]> * rm construct Signed-off-by: chentong319 <[email protected]> * lit test Signed-off-by: chentong319 <[email protected]> * format Signed-off-by: chentong319 <[email protected]> * fix merge Signed-off-by: chentong319 <[email protected]> * comment Signed-off-by: chentong319 <[email protected]> * review respond Signed-off-by: chentong319 <[email protected]> * fix Signed-off-by: chentong319 <[email protected]> * format Signed-off-by: chentong319 <[email protected]> Co-authored-by: Tung D. Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation for
torch.embedding_bag(https://pytorch.org/docs/stable/generated/torch.nn.functional.embedding_bag.html),the default value for
scale_grad_by_freqis False.