Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E support for AtenRemainderScalarOp #1200

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

vidsinghal
Copy link
Collaborator

@vidsinghal vidsinghal commented Aug 9, 2022

trying to fix failing CI
CI fails on Tosa backend.

@vivekkhandelwal1
Copy link
Collaborator

Also, squash all your commits into one.

@vidsinghal vidsinghal force-pushed the aten_remainder_scalar branch 2 times, most recently from 3642222 to 1abc541 Compare August 10, 2022 17:21
Copy link
Collaborator

@ramiro050 ramiro050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have one small change request

@vidsinghal vidsinghal changed the title new branch for Aten remainder scalar E2E support for AtenRemainderScalarOp Aug 10, 2022
@vidsinghal vidsinghal merged commit dd2da5a into llvm:main Aug 11, 2022
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
`verifier` will be obsolete soon to be replaced by `hasVerifier`. This updated the script to use the new form and then applies the updates to the appropriate files.

Signed-off-by: Stella Stamenova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants