-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E support for AtenRemainderScalarOp #1200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiro050
reviewed
Aug 9, 2022
ramiro050
requested changes
Aug 9, 2022
vivekkhandelwal1
requested changes
Aug 10, 2022
Also, squash all your commits into one. |
vidsinghal
force-pushed
the
aten_remainder_scalar
branch
2 times, most recently
from
August 10, 2022 17:21
3642222
to
1abc541
Compare
ramiro050
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have one small change request
vidsinghal
force-pushed
the
aten_remainder_scalar
branch
from
August 10, 2022 17:30
1abc541
to
a1fe87c
Compare
vidsinghal
changed the title
new branch for Aten remainder scalar
E2E support for AtenRemainderScalarOp
Aug 10, 2022
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
`verifier` will be obsolete soon to be replaced by `hasVerifier`. This updated the script to use the new form and then applies the updates to the appropriate files. Signed-off-by: Stella Stamenova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to fix failing CI
CI fails on Tosa backend.