[MLIR][TORCH] Add support for dim=None to Aten[Var|Std]DimOp
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powderluv
approved these changes
Aug 5, 2022
PyTorch recently added support for `dim=None` in the `torch.var` (pytorch/pytorch@5ca9b2b) and `torch.std`op (pytorch/pytorch@eb0e30e). This commit adds the corresponding support in torch-mlir. Signed-Off By: Vivek Khandelwal<[email protected]>
vivekkhandelwal1
force-pushed
the
fix-var-dim-op
branch
from
ac477c3
to
bd6b632
Compare
qedawkins
pushed a commit
to nod-ai/torch-mlir
that referenced
this pull request
Oct 3, 2022
…NonMaxSuppression (llvm#1159) * Fix wrong computation of the effective number of selected indices in NonMaxSuppression Signed-off-by: Tung D. Le <[email protected]> * Fix issue llvm#1145 - error lowering onnx.Cast Signed-off-by: Ettore Tiotto <[email protected]> Signed-off-by: Tung D. Le <[email protected]> * Fix issue llvm#1145 - error lowering onnx.Cast Signed-off-by: Ettore Tiotto <[email protected]> Signed-off-by: Tung D. Le <[email protected]> * Update comments Signed-off-by: Tung D. Le <[email protected]> Signed-off-by: Tung D. Le <[email protected]> * Remove '\r' in commit message when constructing build description (llvm#1162) Signed-off-by: Gong Su <[email protected]> Signed-off-by: Tung D. Le <[email protected]> Co-authored-by: Ettore Tiotto <[email protected]> Co-authored-by: gongsu832 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch recently added support for
dim=Nonein thetorch.var(pytorch/pytorch@5ca9b2b)
and
torch.stdop (pytorch/pytorch@eb0e30e).This commit adds the corresponding support in torch-mlir.
Signed-Off By: Vivek Khandelwal[email protected]