Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dim=None to AtenMeanDimOp #1129

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

ramiro050
Copy link
Collaborator

PyTorch recently added support for dim=None in the torch.mean
op (pytorch/pytorch@2bfae07). This
commit adds the corresponding support in torch-mlir.

PyTorch recently added support for `dim=None` in the `torch.mean`
op (pytorch/pytorch@2bfae07). This
commit adds the corresponding support in torch-mlir.
Copy link
Collaborator

@vivekkhandelwal1 vivekkhandelwal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramiro050 ramiro050 merged commit a7af1fd into llvm:main Aug 2, 2022
@ramiro050 ramiro050 deleted the fix-mean-dim branch August 2, 2022 16:08
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
Update workflow document to be more in line with GigHub web interface which greatly simplify the generation of compact history and log using the "Squash and merge" option combined with editing of the history message.

Author: Alexandre Eichenberger <[email protected]>
Author: Gheorghe-Teodor Bercea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants