Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TorchToStd.cpp is out of date #409

Closed
silvasean opened this issue Nov 10, 2021 · 5 comments
Closed

TorchToStd.cpp is out of date #409

silvasean opened this issue Nov 10, 2021 · 5 comments
Labels
good first issue Good for newcomers

Comments

@silvasean
Copy link
Contributor

A lot of the patterns there should be moved to a new TorchToArith.cpp conversion, now that arith dialect was split out of std.
@silvasean silvasean added the good first issue Good for newcomers label Nov 10, 2021
@silvasean silvasean mentioned this issue Nov 10, 2021
Merged
@stellaraccident
Copy link
Collaborator

Can we just call all of these ConvertToTheDialectFormerlyKnownAsStandard :)

(Rip Prince)

@stephenneuendorffer
Copy link
Contributor

I've submitted a unicode community request to reserve a symbol for "TheDialectFormerlyKnownAsStandard". Design ideas would be appreciated.

@silvasean
Copy link
Contributor Author

We have two options TorchTo〄.cpp and TorchTo㉿.cpp

Those are "U+3004 japanese industrial standard symbol" and "U+327F korean standard symbol".

I have created a poll:

u99127 pushed a commit to u99127/torch-mlir that referenced this issue Aug 5, 2022
Rename TorchToStd pass as TorchToArith
f1b801e 
All the converters in this pass appear to create ops from the
arith dialect. Hence the full rename.

Fix GH Issue llvm#409.
@u99127 u99127 mentioned this issue Aug 5, 2022
Merged
u99127 pushed a commit to u99127/torch-mlir that referenced this issue Aug 10, 2022
Rename TorchToStd pass as TorchToArith
a48067b 
All the converters in this pass appear to create ops from the
arith dialect. Hence the full rename.

Fix GH Issue llvm#409.
u99127 pushed a commit that referenced this issue Aug 10, 2022
Rename TorchToStd pass as TorchToArith (#1163)
738f4fe 
All the converters in this pass appear to create ops from the
arith dialect. Hence the full rename.

Fix GH Issue #409.
@u99127
Copy link
Contributor

u99127 commented Aug 11, 2022

now fixed with #1163 and #1210

@u99127 u99127 closed this as completed Aug 11, 2022
@silvasean
Copy link
Contributor Author

Thanks for fixing this!!

qedawkins pushed a commit to nod-ai/torch-mlir that referenced this issue Oct 3, 2022
@tjingrant
Print error message. (llvm#409)
45bdc5c 
* print error msg.

* Output program path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stephenneuendorffer @stellaraccident @u99127 @silvasean