[compiler-rt] Add missing carry to 128x128->256 wide multiply #97257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
beetrees
force-pushed
the
fix-128-wide-mul
branch
from
192e368
to
f33d937
Compare
All these tests probably should change to use __float128 with the |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Ping @compnerd per CODE_OWNERS.TXT. |
compnerd
approved these changes
Aug 18, 2024
|
@beetrees is this waiting on anything other than somebody to land it? |
|
Not as far as I know. I don't have commit access, so I can't merge it myself. cc @compnerd |
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Sep 26, 2024
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition
r0 + (r1 << 64)when calculatinglocan overflow. This PR makes sure the overflow is carried intohi.Credit to @marthadev for the Rust version of this fix in rust-lang/compiler-builtins#587 (comment).
I've tested the fix works locally. I've also added a test to this PR for the fix, although I can't run it locally as the
__multf3test is only run on platforms wherelong doubleis f128.(Note to reviewer: I don't have commit access)
Fixes #90009
Fixes #91840