Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Make token optional #88699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Workflow] Make token optional #88699

wants to merge 1 commit into from

Conversation

pmatos
Copy link
Contributor

@pmatos pmatos commented Apr 15, 2024

Also fix typo in help string for --token.
Fixes #88697

Also fix typo in help string for --token.
Fixes llvm#88697
@llvmbot
Copy link
Member

llvmbot commented Apr 16, 2024

@llvm/pr-subscribers-github-workflow

Author: Paulo Matos (pmatos)

Changes

Also fix typo in help string for --token.
Fixes #88697


Full diff: https://github.com/llvm/llvm-project/pull/88699.diff

1 Files Affected:

  • (modified) llvm/utils/git/code-format-helper.py (+1-1)
diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py
index f1207026704e88..5b47206d93f229 100755
--- a/llvm/utils/git/code-format-helper.py
+++ b/llvm/utils/git/code-format-helper.py
@@ -340,7 +340,7 @@ def hook_main():
 
     parser = argparse.ArgumentParser()
     parser.add_argument(
-        "--token", type=str, required=True, help="GitHub authentiation token"
+        "--token", type=str, required=False, help="GitHub authentication token"
     )
     parser.add_argument(
         "--repo",

Copy link
Collaborator

@tru tru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

token argument should be optional
4 participants