-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MemCpyOpt] Forward memcpy
based on the actual copy memory location.
#87190
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fc89492
Pre-commit test cases
DianQK d5a966c
[MemCpyOpt] Calculate the offset value to forward `memcpy`
DianQK 289b44d
Fix nits
DianQK d238bb8
Add comments for the forward offset
DianQK a34be73
Update memcpy-memcpy-offset.ll
DianQK 1da22cd
Leave some FIXME comments
DianQK 143c92c
Update due to rebase
DianQK 351eb0a
Update memcpy-offset.ll & Disable 98321
DianQK c197dd1
Re-enable 98321
DianQK a43d005
Re-generate lifetime.ll
DianQK c828a2f
Add nikic's comment
DianQK ba0188d
Only delete the instruction we created
DianQK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,203 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4 | ||
; RUN: opt < %s -passes=memcpyopt -S -verify-memoryssa | FileCheck %s | ||
|
||
%buf = type [9 x i8] | ||
|
||
; We can forward `memcpy` because the copy location are the same, | ||
define void @forward_offset(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @forward_offset( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: [[SRC_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memmove.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP1]], i64 6, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
ret void | ||
} | ||
|
||
; We need to update the align value of the source of `memcpy` when forwarding. | ||
define void @forward_offset_align(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @forward_offset_align( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 4 [[SRC]], i64 9, i1 false) | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 3 | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 3 | ||
; CHECK-NEXT: call void @llvm.memmove.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP1]], i64 5, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 4 %src, i64 9, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 3 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 5, i1 false) | ||
ret void | ||
} | ||
|
||
; We can change the align value to 2 when forwarding. | ||
define void @forward_offset_align_2(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @forward_offset_align_2( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 4 [[SRC]], i64 9, i1 false) | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 2 | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 2 | ||
; CHECK-NEXT: call void @llvm.memmove.p0.p0.i64(ptr align 1 [[DEST]], ptr align 2 [[TMP1]], i64 6, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 4 %src, i64 9, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 2 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
ret void | ||
} | ||
|
||
; If the copy destination can be used as the copy source, we don't need to create a GEP instruction. | ||
define void @forward_offset_without_gep(ptr %src) { | ||
; CHECK-LABEL: define void @forward_offset_without_gep( | ||
; CHECK-SAME: ptr [[SRC:%.*]]) { | ||
; CHECK-NEXT: [[TMP:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[TMP]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[TMP]], i64 1 | ||
; CHECK-NEXT: [[DEST:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 1 | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
%dest = getelementptr inbounds i8, ptr %src, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
ret void | ||
} | ||
|
||
; We need to create a GEP instruction when forwarding. | ||
define void @forward_offset_with_gep(ptr %src) { | ||
; CHECK-LABEL: define void @forward_offset_with_gep( | ||
; CHECK-SAME: ptr [[SRC:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: [[DEST:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 2 | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memmove.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP1]], i64 6, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
%dest = getelementptr inbounds i8, ptr %src, i64 2 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
ret void | ||
} | ||
|
||
; Make sure we pass the right parameters when calling `memcpy`. | ||
define void @forward_offset_memcpy(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @forward_offset_memcpy( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memmove.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP1]], i64 6, i1 false) | ||
; CHECK-NEXT: call void @use(ptr [[DEST]]) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
call void @use(ptr %dest) | ||
ret void | ||
} | ||
|
||
; Make sure we pass the right parameters when calling `memcpy.inline`. | ||
define void @forward_offset_memcpy_inline(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @forward_offset_memcpy_inline( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.inline.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP1]], i64 6, i1 false) | ||
; CHECK-NEXT: call void @use(ptr [[DEST]]) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
call void @llvm.memcpy.inline.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
call void @use(ptr %dest) | ||
ret void | ||
} | ||
|
||
; We cannot forward `memcpy` because it exceeds the size of `memcpy` it depends on. | ||
define void @do_not_forward_oversize_offset(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @do_not_forward_oversize_offset( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 6, i1 false) | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP_OFFSET]], i64 6, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 6, i1 false) | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 6, i1 false) | ||
ret void | ||
} | ||
|
||
; We can forward `memcpy` because the write operation does not corrupt the location to be copied. | ||
define void @forward_offset_and_store(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @forward_offset_and_store( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: store i8 1, ptr [[SRC]], align 1 | ||
; CHECK-NEXT: [[DEP_SRC_END:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 6 | ||
; CHECK-NEXT: store i8 1, ptr [[DEP_SRC_END]], align 1 | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memmove.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP1]], i64 5, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
store i8 1, ptr %src, align 1 | ||
%src_end = getelementptr inbounds i8, ptr %src, i64 6 | ||
store i8 1, ptr %src_end, align 1 | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 5, i1 false) | ||
ret void | ||
} | ||
|
||
; We cannot forward `memcpy` because the write operation alters the location to be copied. | ||
; Also, make sure we have removed the GEP instruction that was created temporarily. | ||
define void @do_not_forward_offset_and_store(ptr %src, ptr %dest) { | ||
; CHECK-LABEL: define void @do_not_forward_offset_and_store( | ||
; CHECK-SAME: ptr [[SRC:%.*]], ptr [[DEST:%.*]]) { | ||
; CHECK-NEXT: [[DEP_DEST:%.*]] = alloca [9 x i8], align 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEP_DEST]], ptr align 1 [[SRC]], i64 7, i1 false) | ||
; CHECK-NEXT: [[DEP:%.*]] = getelementptr inbounds i8, ptr [[SRC]], i64 1 | ||
; CHECK-NEXT: store i8 1, ptr [[DEP]], align 1 | ||
; CHECK-NEXT: [[TMP_OFFSET:%.*]] = getelementptr inbounds i8, ptr [[DEP_DEST]], i64 1 | ||
; CHECK-NEXT: call void @llvm.memcpy.p0.p0.i64(ptr align 1 [[DEST]], ptr align 1 [[TMP_OFFSET]], i64 5, i1 false) | ||
; CHECK-NEXT: ret void | ||
; | ||
%cpy_tmp = alloca %buf, align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %cpy_tmp, ptr align 1 %src, i64 7, i1 false) | ||
%src_offset = getelementptr inbounds i8, ptr %src, i64 1 | ||
store i8 1, ptr %src_offset, align 1 | ||
%cpy_tmp_offset = getelementptr inbounds i8, ptr %cpy_tmp, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr align 1 %dest, ptr align 1 %cpy_tmp_offset, i64 5, i1 false) | ||
ret void | ||
} | ||
|
||
declare void @use(ptr) | ||
|
||
declare void @llvm.memcpy.p0.p0.i64(ptr nocapture, ptr nocapture, i64, i1) | ||
declare void @llvm.memcpy.inline.p0.p0.i64(ptr nocapture, ptr nocapture, i64, i1) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 4 | ||
; RUN: opt < %s -passes=memcpyopt,instcombine -S -verify-memoryssa | FileCheck --check-prefix=CUSTOM %s | ||
; RUN: opt < %s -O2 -S | FileCheck --check-prefix=O2 %s | ||
|
||
; Check that we eliminate all `memcpy` calls in this function. | ||
define void @memcpy_forward_back_with_offset(ptr %arg) { | ||
; CUSTOM-LABEL: define void @memcpy_forward_back_with_offset( | ||
; CUSTOM-SAME: ptr [[ARG:%.*]]) { | ||
; CUSTOM-NEXT: store i8 1, ptr [[ARG]], align 1 | ||
; CUSTOM-NEXT: ret void | ||
; | ||
; O2-LABEL: define void @memcpy_forward_back_with_offset( | ||
; O2-SAME: ptr nocapture writeonly [[ARG:%.*]]) local_unnamed_addr #[[ATTR0:[0-9]+]] { | ||
; O2-NEXT: store i8 1, ptr [[ARG]], align 1 | ||
; O2-NEXT: ret void | ||
; | ||
%i = alloca [753 x i8], align 1 | ||
%i1 = alloca [754 x i8], align 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr %i1, ptr %arg, i64 754, i1 false) | ||
%i2 = getelementptr inbounds i8, ptr %i1, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr %i, ptr %i2, i64 753, i1 false) | ||
store i8 1, ptr %arg, align 1 | ||
%i3 = getelementptr inbounds i8, ptr %arg, i64 1 | ||
call void @llvm.memcpy.p0.p0.i64(ptr %i3, ptr %i, i64 753, i1 false) | ||
ret void | ||
} | ||
|
||
declare void @llvm.memcpy.p0.p0.i64(ptr, ptr, i64, i1) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the bulk of the coverage not copy back into the same allocation, but into a separate (noalias) destination. The same-allocation case is a confusing edge-case where we should only verify that we switch to memmove in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.