-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] Add git to Linux container #82687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failure in the stage2 container build is transient (or at least it was in the past). In the past I've been able to resolve it by just rerunning the stage2 job, but in this case that doesn't seem to work. I need to do some investigation there, but it's not super trivial to do experimentation given the total job sequence takes ~8 hours on the self-hosted github runners at this point.
Could we temporarily make the existing container a base container and then just install git on top of it? |
This reverts commit 5f285dded2b7bf0bf8d63f61b524719bce12673e.
172803a
to
7898ca4
Compare
@llvm/pr-subscribers-github-workflow Author: Natalie Chouinard (sudonatalie) ChangesFixes #82646 Full diff: https://github.com/llvm/llvm-project/pull/82687.diff 1 Files Affected:
diff --git a/.github/workflows/containers/github-action-ci/stage2.Dockerfile b/.github/workflows/containers/github-action-ci/stage2.Dockerfile
index e1a06cb68a589e..0ca0da87734c4c 100644
--- a/.github/workflows/containers/github-action-ci/stage2.Dockerfile
+++ b/.github/workflows/containers/github-action-ci/stage2.Dockerfile
@@ -12,11 +12,13 @@ COPY --from=stage2-toolchain $LLVM_SYSROOT $LLVM_SYSROOT
# Need to install curl for hendrikmuhs/ccache-action
# Need nodejs for some of the GitHub actions.
# Need perl-modules for clang analyzer tests.
+# Need git for SPIRV-Tools tests.
RUN apt-get update && \
apt-get install -y \
binutils \
cmake \
curl \
+ git \
libstdc++-11-dev \
ninja-build \
nodejs \
|
Checks are passing following #83707 ! |
Fixes #82646