[Release] Don't build during test-release.sh Phase 3 install #82001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in [test-release.sh ninja install does builds in Phase 3](llvm#80999), considerable parts of Phase 3 of a `test-release.sh` build are run by `ninja install`, ignoring both `$Verbose` and the parallelism set via `-j NUM`. This patches fixes this by not specifying any explicit build target for Phase 3, thus running the full build as usual. Tested on `sparc64-unknown-linux-gnu`.
tstellar
reviewed
Feb 16, 2024
| if [ "$Phase" -eq "3" ]; then | ||
| # Build everything at once, with the proper parallelism and verbosity, | ||
| # in Phase 3. | ||
| BuildTarget= |
There was a problem hiding this comment.
Does this actually change anything? Isn't this variable already unset?
There was a problem hiding this comment.
IIUC, BuildTarget is global, so stays unchanged from previous Phases unless reset. That's what I see in the build logs when comparing rc1 (with unchanged test-release.sh) and rc2 (with locally patched test-release.sh):
rc1:
Phase 3: Building llvmCore
[...]
# Compiling llvm 18.1.0-rc1 Release
# ninja -j 8 -v
[1/4140
[...]
# Installing llvm 18.1.0-rc1 Release
# ninja install
[1/4093] Creating export file for LLVMHello
[2/4093] Building CXX object lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/HardwareUnit.cpp.o
vs. rc2:
# Phase 3: Building llvmCore
[...]
# Compiling llvm 18.1.0-rc2 Release
# ninja -j 12 -v
[1/8225]
[...]
# Installing llvm 18.1.0-rc2 Release
# ninja install
[0/8] Performing build step for 'builtins'
i.e. with the patched script, in Phase 3 way more targets are actually built (with proper -v and -jN) in the build phase and nothing's built during ninja install, as it should be (and where the default parallelism does no harm).
tstellar
approved these changes
Feb 20, 2024
|
/cherry-pick f6ac598 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 20, 2024
) As described in [test-release.sh ninja install does builds in Phase 3](llvm#80999), considerable parts of Phase 3 of a `test-release.sh` build are run by `ninja install`, ignoring both `$Verbose` and the parallelism set via `-j NUM`. This patches fixes this by not specifying any explicit build target for Phase 3, thus running the full build as usual. Tested on `sparc64-unknown-linux-gnu`. (cherry picked from commit f6ac598)
|
/pull-request #82420 |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Feb 21, 2024
) As described in [test-release.sh ninja install does builds in Phase 3](llvm#80999), considerable parts of Phase 3 of a `test-release.sh` build are run by `ninja install`, ignoring both `$Verbose` and the parallelism set via `-j NUM`. This patches fixes this by not specifying any explicit build target for Phase 3, thus running the full build as usual. Tested on `sparc64-unknown-linux-gnu`. (cherry picked from commit f6ac598)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in test-release.sh ninja install does builds in Phase 3, considerable parts of Phase 3 of a
test-release.shbuild are run byninja install, ignoring both$Verboseand the parallelism set via-j NUM.This patches fixes this by not specifying any explicit build target for Phase 3, thus running the full build as usual.
Tested on
sparc64-unknown-linux-gnu.