Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update release notes for APX relocation types #118575

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

fzou1
Copy link
Contributor

@fzou1 fzou1 commented Dec 4, 2024

No description provided.

@llvmbot llvmbot added the lld label Dec 4, 2024
@fzou1 fzou1 changed the title [docs] Update release notes for apx reloc [docs] Update release notes for APX relocation types Dec 4, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 4, 2024

@llvm/pr-subscribers-lld

Author: Feng Zou (fzou1)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/118575.diff

2 Files Affected:

  • (modified) lld/docs/ReleaseNotes.rst (+5)
  • (modified) llvm/docs/ReleaseNotes.md (+7)
diff --git a/lld/docs/ReleaseNotes.rst b/lld/docs/ReleaseNotes.rst
index e8b27aaf840585..b8eda14e593bd1 100644
--- a/lld/docs/ReleaseNotes.rst
+++ b/lld/docs/ReleaseNotes.rst
@@ -35,6 +35,11 @@ ELF Improvements
   globally changing the semantics of section matching. It also independently
   increases the expressive power of linker scripts.
   (`#95323 <https://github.com/llvm/llvm-project/pull/95323>`_)
+* Supported relocation types for X86_64 target:
+  * ``R_X86_64_CODE_4_GOTPCRELX`` (`#109783 <https://github.com/llvm/llvm-project/pull/109783>`_ and `#116737 <https://github.com/llvm/llvm-project/pull/116737>`_)
+  * ``R_X86_64_CODE_4_GOTTPOFF`` (`#116634 <https://github.com/llvm/llvm-project/pull/116634>`_)
+  * ``R_X86_64_CODE_4_GOTPC32_TLSDESC`` (`#116909 <https://github.com/llvm/llvm-project/pull/116909>`_)
+  * ``R_X86_64_CODE_6_GOTTPOFF``  (`#117675 <https://github.com/llvm/llvm-project/pull/117675>`_)
 
 Breaking changes
 ----------------
diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md
index d8d9c4fc4bb8a5..b15bf346f71055 100644
--- a/llvm/docs/ReleaseNotes.md
+++ b/llvm/docs/ReleaseNotes.md
@@ -265,6 +265,13 @@ Changes to the X86 Backend
 
 * Supported ``-mcpu=diamondrapids``
 
+* Supported emitting relocation types for X86_64 target:
+  * `R_X86_64_CODE_4_GOTPCRELX`
+  * `R_X86_64_CODE_4_GOTTPOFF`
+  * `R_X86_64_CODE_4_GOTPC32_TLSDESC`
+  * `R_X86_64_CODE_6_GOTTPOFF`
+
+
 Changes to the OCaml bindings
 -----------------------------
 

@fzou1
Copy link
Contributor Author

fzou1 commented Dec 4, 2024

It depends on #117675. I'll ask for review after that PR is merged. Thanks.

@@ -35,6 +35,11 @@ ELF Improvements
globally changing the semantics of section matching. It also independently
increases the expressive power of linker scripts.
(`#95323 <https://github.com/llvm/llvm-project/pull/95323>`_)
* Supported relocation types for X86_64 target:
* ``R_X86_64_CODE_4_GOTPCRELX`` (`#109783 <https://github.com/llvm/llvm-project/pull/109783>`_ and `#116737 <https://github.com/llvm/llvm-project/pull/116737>`_)
Copy link
Contributor

@phoebewang phoebewang Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use

(`#109783 <https://github.com/llvm/llvm-project/pull/109783>`_) (`#116737 <https://github.com/llvm/llvm-project/pull/116737>`_)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X86_64 => x86-64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Contributor

@phoebewang phoebewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KanRobert KanRobert merged commit 94c6dd6 into llvm:main Dec 7, 2024
9 checks passed
@fzou1 fzou1 deleted the update_release_notes_for_APX_reloc branch December 7, 2024 14:39
broxigarchen pushed a commit to broxigarchen/llvm-project that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants