Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add clang::lifetimebound annotation to llvm::function_ref (#1… #115376

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pranavk
Copy link
Contributor

@pranavk pranavk commented Nov 7, 2024

…15019)"

This reverts commit 9f79615.

This is breaking compiler-rt/lib/sanitizer_common/...

Author knows about the breakage.

…vm#115019)"

This reverts commit 9f79615.

This is breaking compiler-rt/lib/sanitizer_common/...

Author knows about the breakage.
@pranavk
Copy link
Contributor Author

pranavk commented Nov 7, 2024

@hokein

@llvmbot
Copy link
Collaborator

llvmbot commented Nov 7, 2024

@llvm/pr-subscribers-llvm-adt

Author: Pranav Kant (pranavk)

Changes

…15019)"

This reverts commit 9f79615.

This is breaking compiler-rt/lib/sanitizer_common/...

Author knows about the breakage.


Full diff: https://github.com/llvm/llvm-project/pull/115376.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/STLFunctionalExtras.h (+1-2)
diff --git a/llvm/include/llvm/ADT/STLFunctionalExtras.h b/llvm/include/llvm/ADT/STLFunctionalExtras.h
index 3b9d40959d7142..6f172504b3c167 100644
--- a/llvm/include/llvm/ADT/STLFunctionalExtras.h
+++ b/llvm/include/llvm/ADT/STLFunctionalExtras.h
@@ -16,7 +16,6 @@
 #define LLVM_ADT_STLFUNCTIONALEXTRAS_H
 
 #include "llvm/ADT/STLForwardCompat.h"
-#include "llvm/Support/Compiler.h"
 
 #include <cstdint>
 #include <type_traits>
@@ -53,7 +52,7 @@ class function_ref<Ret(Params...)> {
 
   template <typename Callable>
   function_ref(
-      Callable &&callable LLVM_LIFETIME_BOUND,
+      Callable &&callable,
       // This is not the copy-constructor.
       std::enable_if_t<!std::is_same<remove_cvref_t<Callable>,
                                      function_ref>::value> * = nullptr,

@pranavk pranavk merged commit e109c49 into llvm:main Nov 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants