-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NVPTX] Promote v2i8 to v2i16 (#111189) #115081
base: release/19.x
Are you sure you want to change the base?
Conversation
@llvm/pr-subscribers-backend-nvptx Author: Artem Belevich (Artem-B) ChangesPromote v2i8 to v2i16, fixes a crash. Partial cherry-pick of fda2fea w/o the test which does not exist in release/19.x Full diff: https://github.com/llvm/llvm-project/pull/115081.diff 1 Files Affected:
diff --git a/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp b/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
index 6975412ce5d35b..b2153a7afe7365 100644
--- a/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp
@@ -229,6 +229,10 @@ static void ComputePTXValueVTs(const TargetLowering &TLI, const DataLayout &DL,
// v*i8 are formally lowered as v4i8
EltVT = MVT::v4i8;
NumElts = (NumElts + 3) / 4;
+ } else if (EltVT.getSimpleVT() == MVT::i8 && NumElts == 2) {
+ // v2i8 is promoted to v2i16
+ NumElts = 1;
+ EltVT = MVT::v2i16;
}
for (unsigned j = 0; j != NumElts; ++j) {
ValueVTs.push_back(EltVT);
|
This seems to have some CI errors, Can you rebase on latest and see if the windows build errors are legit? |
536f809
to
ed0fe30
Compare
The CI check was unhappy because PR was based on the tree before 19.1.4. I've rebased it on top of the most recent commit. |
Who can review this? |
That would be me -- I did the review of the original patch and just doing the legwork here to cherry-pick it into the 19.x branch. If you need somebody else, I'd ask @AlexMaclean |
Can you back out the merge commit? It needs to be rebased in order to go in cleanly with our scripts. |
6628cce
to
e0a9e99
Compare
Done. |
Promote v2i8 to v2i16, fixes a crash. Re-enable a test in NVPTX/vector-returns.ll Partial cherry-pick of fda2fea w/o the test which does not exist in release/19.x llvm#104864
e0a9e99
to
02930b8
Compare
Promote v2i8 to v2i16, fixes a crash.
Re-enable a test in NVPTX/vector-returns.ll
Partial cherry-pick of fda2fea w/o the test which does not exist in release/19.x
#104864