Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remarks] Fix missing include in HotnessThresholdParser for Expected #113755

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

fsfod
Copy link
Contributor

@fsfod fsfod commented Oct 26, 2024

The use of Expected<> requires llvm/Support/Error.h to be included.

The use of Expected<> requires llvm/Support/Error.h to be included.
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 14171b0 into llvm:main Oct 28, 2024
9 checks passed
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
…lvm#113755)

The use of Expected<> requires llvm/Support/Error.h to be included.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants