Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clangd] Update clangDaemonTweaks to set symbol visibility macros #112304

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[clangd] Update clangDaemonTweaks to set symbol visibility macros #112304

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d41e927
[clangd] Update clangDaemonTweaks to set symbol visibility macros cor…
fsfod Oct 15, 2024
732af54
Add a CLANG_EXPORT arg to add_clang_library cmake function instead of…
fsfod Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/cmake/modules/AddClang.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ endmacro()

macro(add_clang_library name)
cmake_parse_arguments(ARG
"SHARED;STATIC;INSTALL_WITH_TOOLCHAIN"
"SHARED;STATIC;OBJECT;INSTALL_WITH_TOOLCHAIN;CLANG_EXPORT"
""
"ADDITIONAL_HEADERS"
${ARGN})
Expand Down Expand Up @@ -114,7 +114,7 @@ macro(add_clang_library name)
if(TARGET "obj.${name}")
target_compile_definitions("obj.${name}" PUBLIC CLANG_BUILD_STATIC)
endif()
elseif(NOT ARG_SHARED AND NOT ARG_STATIC)
elseif(ARG_CLANG_EXPORT OR NOT (ARG_SHARED OR ARG_STATIC OR ARG_OBJECT))
# Clang component libraries linked in to clang-cpp are declared without SHARED or STATIC
target_compile_definitions("obj.${name}" PUBLIC CLANG_EXPORTS)
endif()
Expand Down
Loading