[Clang] Update Interpreter tests to use clang_target_link_libraries #110154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Thomas Fransham (fsfod) ChangesThis will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. Full diff: https://github.com/llvm/llvm-project/pull/110154.diff 1 Files Affected:
diff --git a/clang/unittests/Interpreter/CMakeLists.txt b/clang/unittests/Interpreter/CMakeLists.txt
index ec6f81ea19b960..1ed1216c772e8f 100644
--- a/clang/unittests/Interpreter/CMakeLists.txt
+++ b/clang/unittests/Interpreter/CMakeLists.txt
@@ -16,13 +16,15 @@ add_clang_unittest(ClangReplInterpreterTests
EXPORT_SYMBOLS
)
-target_link_libraries(ClangReplInterpreterTests PUBLIC
+
+target_link_libraries(ClangReplInterpreterTests PUBLIC LLVMTestingSupport)
+
+clang_target_link_libraries(ClangReplInterpreterTests PRIVATE
clangAST
clangBasic
clangInterpreter
clangFrontend
clangSema
- LLVMTestingSupport
)
# Exceptions on Windows are not yet supported.
|
Open
40 tasks
vgvassilev
force-pushed
the
exported-api/interp-test-fix
branch
3 times, most recently
from
5658a27 to
a9d8655
Compare
fsfod
force-pushed
the
exported-api/interp-test-fix
branch
2 times, most recently
from
064bc85 to
e58b244
Compare
This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
vgvassilev
force-pushed
the
exported-api/interp-test-fix
branch
from
e58b244 to
23e9dc9
Compare
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
…lvm#110154) This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
VitaNuo
pushed a commit
to VitaNuo/llvm-project
that referenced
this pull request
Oct 2, 2024
…lvm#110154) This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
…lvm#110154) This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
xgupta
pushed a commit
to xgupta/llvm-project
that referenced
this pull request
Oct 4, 2024
…lvm#110154) This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used. This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix duplicate and missing linker symbol errors when using CLANG_LINK_CLANG_DYLIB on windows and explicit visibility macros are used.
This is part of the work to enable LLVM_BUILD_LLVM_DYLIB and plugins on window.