Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/19.x: [C++20] [Modules] Treat constexpr/consteval member function as implicitly inline #109076

Merged
merged 1 commit into from
Sep 24, 2024
+13 −0
Merged

release/19.x: [C++20] [Modules] Treat constexpr/consteval member function as implicitly inline #109076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clang/lib/Sema/SemaDecl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9732,6 +9732,7 @@ Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC,
// the function decl is created above).
// FIXME: We need a better way to separate C++ standard and clang modules.
bool ImplicitInlineCXX20 = !getLangOpts().CPlusPlusModules ||
NewFD->isConstexpr() || NewFD->isConsteval() ||
!NewFD->getOwningModule() ||
NewFD->isFromExplicitGlobalModule() ||
NewFD->getOwningModule()->isHeaderLikeModule();
Expand Down
12 changes: 12 additions & 0 deletions clang/test/Modules/pr107673.cppm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// RUN: %clang_cc1 -std=c++20 %s -ast-dump | FileCheck %s
export module a;
export class f {
public:
void non_inline_func() {}
constexpr void constexpr_func() {}
consteval void consteval_func() {}
};

// CHECK-NOT: non_inline_func {{.*}}implicit-inline
// CHECK: constexpr_func {{.*}}implicit-inline
// CHECK: consteval_func {{.*}}implicit-inline
Loading