[libc++] -DLIBCXX_CXX_ABI=system-libcxxabi not usable?

[h-vetinari]

I recently noticed ba4f1e4, which is exactly the kind of build we need to do for our distribution for various reasons. I've tried this with LLVM 18.1.8 and 19.1.0-rc2, but in both cases, I get

-- Configuring done (25.4s)
CMake Error at $SRC_DIR/libcxx/cmake/Modules/HandleLibCXXABI.cmake:59 (add_library):
  No SOURCES given to target: libcxx-abi-headers-generate-private-headers
Call Stack (most recent call first):
  $SRC_DIR/libcxx/cmake/Modules/HandleLibCXXABI.cmake:135 (import_private_headers)
  $SRC_DIR/libcxx/CMakeLists.txt:511 (include)

Our build invocation roughly boils down to the following (removed some uninteresting things, but happy to elaborate);

cmake -G Ninja -B build -S runtimes \
    -DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi;libunwind \
    -DCMAKE_INSTALL_PREFIX=$PREFIX \
    -DCMAKE_BUILD_TYPE=Release \
    -DLIBCXX_ENABLE_TIME_ZONE_DATABASE=ON \
    -DLIBCXX_INCLUDE_BENCHMARKS=OFF \
    -DLIBCXX_INCLUDE_DOCS=OFF \
    -DLIBCXX_INCLUDE_TESTS=OFF \
    -DLIBCXX_HARDENING_MODE=none \
    -DLIBCXXABI_USE_LLVM_UNWINDER=OFF \
    -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF \
    -DCMAKE_OSX_DEPLOYMENT_TARGET=10.13 \
    -DLIBCXX_ENABLE_VENDOR_AVAILABILITY_ANNOTATIONS=ON \
    -DLIBCXX_CXX_ABI=system-libcxxabi

ninja -C build cxx cxxabi unwind

I've tried removing libcxxabi from -DLLVM_ENABLE_RUNTIMES= (and the build invocation) though the result stays the same.

CC @ldionne @mgorny

[h-vetinari]

Gentle ping @ldionne

[h-vetinari]

Gentle ping @mgorny @ldionne

[mgorny]

Hmm, FWICS system-libcxxabi does work for us. I can't look at it in detail right now but if you're not scared of some bash, here's our ebuild: https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-libs/libcxx/libcxx-20.0.0.9999.ebuild

Note that we're doing only Linux builds, so perhaps the issue is specific to OSX. We're also passing -DLIBCXX_CXX_ABI_INCLUDE_PATHS, not sure if that's relevant. And we're only passing libcxx in -DLLVM_ENABLE_RUNTIMES, since naturally the two other libs are system libs.

[ldionne]

@h-vetinari I think you're missing -DLIBCXX_CXX_ABI_INCLUDE_PATHS="$(xcrun --show-sdk-path)/usr/include/c++/v1". However, note that even when you do that, now the build is going to start trying to re-export a list of libc++abi symbols from libc++, and obviously that only works if your system ABI library is sufficiently recent to have all of those symbols. It's kind of a brittle setup.

[mgorny]

Since we have another week for 19.1.4, let's backport this as well.

[mgorny]

/cherry-pick 5d452ab
/cherry-pick eb85139

[llvmbot]

Failed to cherry-pick: 5d452ab

https://github.com/llvm/llvm-project/actions/runs/11800523880

Please manually backport the fix and push it to your github fork. Once this is done, please create a pull request

[mgorny]

/cherry-pick 21da4e7

[llvmbot]

/pull-request #115892