[FIRRTL][LowerLayers] Remove handling of some ref ops #7640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove code that handles the capturing of ref cast and ref send operands specially, since this code is doing only what the generic capture-handling code does just a few lines below. There is a bug in the handling of ref.cast which is removed by this change: We are accidentally checking that the cast op itself is within the layerblock, when we should actually be checking if its operand is defined within the layerblock. This causes us to incorrectly capture the operand of a ref.cast op. The generic codepath works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code that handles the capturing of ref cast and ref send operands specially, since this code is doing only what the generic capture-handling code does just a few lines below.
There is a bug in the handling of ref.cast which is removed by this change: We are accidentally checking that the cast op itself is within the layerblock, when we should actually be checking if its operand is defined within the layerblock. This causes us to skip converting the captured operand of a ref.cast op into a port. The generic codepath works fine.