[firtool] Move LowerLayers later in pipeline. #7639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LowerLayers belongs with the other passes that lower out of FIRRTL. Start moving it, now that first batch of passes have been fixed to handle enough FIRRTL IR to run in presence of layer operations.
It does appear to fix the result of the example posted. If that resolves the issue sufficiently, then yes. Looks like canonicalization now runs before this as well 🎉 . FWIW I wasn't sure if we wanted to move LayerSink later in the pipeline or not, but figured we can sort that out later (and pipeline placement re:LayerMerge which has other considerations). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LowerLayers belongs with the other passes that lower out of FIRRTL.
Start moving it, now that first batch of passes have been fixed to handle enough FIRRTL IR to run in presence of layer operations.